Thread (2 messages) flat view 2 messages, 2 authors, 2021-10-12

Re: [PATCH v2 net] net: dsa: microchip: Added the condition for scheduling ksz_mib_read_work

From: patchwork-bot+netdevbpf@kernel.org
Date: 2021-10-12 10:40:12
Also in: lkml

Hello:

This patch was applied to netdev/net.git (master)
by David S. Miller [off-list ref]:

On Mon, 11 Oct 2021 21:18:08 +0530 you wrote:
When the ksz module is installed and removed using rmmod, kernel crashes
with null pointer dereferrence error. During rmmod, ksz_switch_remove
function tries to cancel the mib_read_workqueue using
cancel_delayed_work_sync routine and unregister switch from dsa.

During dsa_unregister_switch it calls ksz_mac_link_down, which in turn
reschedules the workqueue since mib_interval is non-zero.
Due to which queue executed after mib_interval and it tries to access
dp->slave. But the slave is unregistered in the ksz_switch_remove
function. Hence kernel crashes.

[...]
Here is the summary with links:
  - [v2,net] net: dsa: microchip: Added the condition for scheduling ksz_mib_read_work
    https://git.kernel.org/netdev/net/c/ef1100ef20f2

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help