[PATCH] [v2] selftests: bpf: Remove duplicated include in cgroup_helpers

Subsystems: bpf [general] (safe dynamic programs and tools), bpf [selftests] (test runners & infrastructure), kernel selftest framework, the rest

STALE1761d LANDED

Landed in mainline as b8f49dce799f on 2021-10-20.

3 messages, 3 authors, 2021-10-20 · open the first message on its own page

[PATCH] [v2] selftests: bpf: Remove duplicated include in cgroup_helpers

From: Wan Jiabing <hidden>
Date: 2021-10-12 02:32:51

Fix following checkincludes.pl warning:
./scripts/checkincludes.pl tools/testing/selftests/bpf/cgroup_helpers.c
tools/testing/selftests/bpf/cgroup_helpers.c: unistd.h is included more
than once.

Signed-off-by: Wan Jiabing <redacted>
---
Changelog:
v2:
- Fix the commit description.
---
 tools/testing/selftests/bpf/cgroup_helpers.c | 1 -
 1 file changed, 1 deletion(-)
diff --git a/tools/testing/selftests/bpf/cgroup_helpers.c b/tools/testing/selftests/bpf/cgroup_helpers.c
index 8fcd44841bb2..9d59c3990ca8 100644
--- a/tools/testing/selftests/bpf/cgroup_helpers.c
+++ b/tools/testing/selftests/bpf/cgroup_helpers.c
@@ -11,7 +11,6 @@
 #include <fcntl.h>
 #include <unistd.h>
 #include <ftw.h>
-#include <unistd.h>
 
 #include "cgroup_helpers.h"
 
-- 
2.30.2

RE: [PATCH] [v2] selftests: bpf: Remove duplicated include in cgroup_helpers

From: John Fastabend <john.fastabend@gmail.com>
Date: 2021-10-18 16:07:11

Wan Jiabing wrote:
Fix following checkincludes.pl warning:
./scripts/checkincludes.pl tools/testing/selftests/bpf/cgroup_helpers.c
tools/testing/selftests/bpf/cgroup_helpers.c: unistd.h is included more
than once.

Signed-off-by: Wan Jiabing <redacted>
---
Changelog:
v2:
- Fix the commit description.
---
The Subject is a bit unusual. Typically it would be something like,

 "[PATCH bpf-next] selftests, remove duplicated include in cgroup_helpers"

For the actual patch though LGTM.

Acked-by: John Fastabend <john.fastabend@gmail.com>

Re: [PATCH] [v2] selftests: bpf: Remove duplicated include in cgroup_helpers

From: Andrii Nakryiko <hidden>
Date: 2021-10-20 17:47:07

On Mon, Oct 18, 2021 at 9:07 AM John Fastabend [off-list ref] wrote:
Wan Jiabing wrote:
quoted
Fix following checkincludes.pl warning:
./scripts/checkincludes.pl tools/testing/selftests/bpf/cgroup_helpers.c
tools/testing/selftests/bpf/cgroup_helpers.c: unistd.h is included more
than once.

Signed-off-by: Wan Jiabing <redacted>
---
Changelog:
v2:
- Fix the commit description.
---
The Subject is a bit unusual. Typically it would be something like,

 "[PATCH bpf-next] selftests, remove duplicated include in cgroup_helpers"
Also for selftests we use "selftests/bpf: " prefix (at least we
generally try, for consistency). Fixed up, applied to bpf-next.
Thanks.
For the actual patch though LGTM.

Acked-by: John Fastabend <john.fastabend@gmail.com>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help