From: Wan Jiabing <hidden> Date: 2021-10-12 02:32:51
Fix following checkincludes.pl warning:
./scripts/checkincludes.pl tools/testing/selftests/bpf/cgroup_helpers.c
tools/testing/selftests/bpf/cgroup_helpers.c: unistd.h is included more
than once.
Signed-off-by: Wan Jiabing <redacted>
---
Changelog:
v2:
- Fix the commit description.
---
tools/testing/selftests/bpf/cgroup_helpers.c | 1 -
1 file changed, 1 deletion(-)
From: John Fastabend <john.fastabend@gmail.com> Date: 2021-10-18 16:07:11
Wan Jiabing wrote:
Fix following checkincludes.pl warning:
./scripts/checkincludes.pl tools/testing/selftests/bpf/cgroup_helpers.c
tools/testing/selftests/bpf/cgroup_helpers.c: unistd.h is included more
than once.
Signed-off-by: Wan Jiabing <redacted>
---
Changelog:
v2:
- Fix the commit description.
---
The Subject is a bit unusual. Typically it would be something like,
"[PATCH bpf-next] selftests, remove duplicated include in cgroup_helpers"
For the actual patch though LGTM.
Acked-by: John Fastabend <john.fastabend@gmail.com>
On Mon, Oct 18, 2021 at 9:07 AM John Fastabend [off-list ref] wrote:
Wan Jiabing wrote:
quoted
Fix following checkincludes.pl warning:
./scripts/checkincludes.pl tools/testing/selftests/bpf/cgroup_helpers.c
tools/testing/selftests/bpf/cgroup_helpers.c: unistd.h is included more
than once.
Signed-off-by: Wan Jiabing <redacted>
---
Changelog:
v2:
- Fix the commit description.
---
The Subject is a bit unusual. Typically it would be something like,
"[PATCH bpf-next] selftests, remove duplicated include in cgroup_helpers"
Also for selftests we use "selftests/bpf: " prefix (at least we
generally try, for consistency). Fixed up, applied to bpf-next.
Thanks.
For the actual patch though LGTM.
Acked-by: John Fastabend <john.fastabend@gmail.com>