Re: [PATCH 1/7] dt-bindings: nfc: nxp,nci: convert to dtschema

On 10/10/2021 21:31, Rob Herring wrote:

On Sun, 10 Oct 2021 16:23:11 +0200, Krzysztof Kozlowski wrote:

quoted

Convert the NXP NCI NFC controller to DT schema format.

Signed-off-by: Krzysztof Kozlowski <redacted>
---
 .../devicetree/bindings/net/nfc/nxp,nci.yaml  | 61 +++++++++++++++++++
 .../devicetree/bindings/net/nfc/nxp-nci.txt   | 33 ----------
 MAINTAINERS                                   |  1 +
 3 files changed, 62 insertions(+), 33 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/net/nfc/nxp,nci.yaml
 delete mode 100644 Documentation/devicetree/bindings/net/nfc/nxp-nci.txt

Running 'make dtbs_check' with the schema in this patch gives the
following warnings. Consider if they are expected or the schema is
incorrect. These may not be new warnings.

Note that it is not yet a requirement to have 0 warnings for dtbs_check.
This will change in the future.

Full log is available here: https://patchwork.ozlabs.org/patch/1539010


nfc@28: 'clock-frequency' is a required property
	arch/arm64/boot/dts/qcom/msm8916-huawei-g7.dt.yaml

nfc@28: compatible:0: 'nxp,nxp-nci-i2c' was expected
	arch/arm64/boot/dts/qcom/msm8916-huawei-g7.dt.yaml

nfc@28: compatible: Additional items are not allowed ('nxp,nxp-nci-i2c' was unexpected)
	arch/arm64/boot/dts/qcom/msm8916-huawei-g7.dt.yaml

nfc@28: compatible: ['nxp,pn547', 'nxp,nxp-nci-i2c'] is too long
	arch/arm64/boot/dts/qcom/msm8916-huawei-g7.dt.yaml

nfc@30: 'clock-frequency' is a required property
	arch/arm/boot/dts/ste-ux500-samsung-janice.dt.yaml

nfc@30: compatible:0: 'nxp,nxp-nci-i2c' was expected
	arch/arm/boot/dts/ste-ux500-samsung-janice.dt.yaml

nfc@30: compatible: Additional items are not allowed ('nxp,nxp-nci-i2c' was unexpected)
	arch/arm/boot/dts/ste-ux500-samsung-janice.dt.yaml

nfc@30: compatible: ['nxp,pn547', 'nxp,nxp-nci-i2c'] is too long
	arch/arm/boot/dts/ste-ux500-samsung-janice.dt.yaml

I missed that new compatible. I'll send a patch adding nxp,nxp-nci-i2c
and try to fix the DTS (missing clock-frequency).

Best regards,
Krzysztof