Thread (30 messages) flat view 30 messages, 4 authors, 2021-10-11

Re: [net-next PATCH v4 02/13] net: dsa: qca8k: add support for sgmii falling edge

From: Vladimir Oltean <olteanv@gmail.com>
Date: 2021-10-10 12:50:09
Also in: linux-devicetree, lkml

On Sun, Oct 10, 2021 at 02:10:00PM +0200, Ansuel Smith wrote:
quoted
I would strongly recommend that you stop accessing dp->dn and add your
own device tree parsing function during probe time. It is also a runtime
invariant, there is no reason to read the device tree during each mac_config.
What would be the correct way to pass all these data? Put all of them in
qca8k_priv? Do we have a cleaner solution?
Put in driver private structures, or configure at probe time and never
modify touch again, anything goes.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help