Thread (29 messages) 29 messages, 7 authors, 2021-10-02

Re: [PATCH] powerpc/fsl/dts: Fix phy-connection-type for fm1mac3

From: Pali Rohár <pali@kernel.org>
Date: 2021-10-02 09:06:57
Also in: linux-devicetree, lkml

On Wednesday 29 September 2021 16:25:01 Andrew Lunn wrote:
On Tue, Sep 28, 2021 at 11:39:18PM +0200, Pali Rohár wrote:
quoted
On Friday 27 August 2021 13:38:36 Pali Rohár wrote:
quoted
On Wednesday 14 July 2021 12:11:49 Scott Wood wrote:
quoted
On Sun, 2021-07-04 at 15:43 +0200, Pali Rohár wrote:
quoted
Property phy-connection-type contains invalid value "sgmii-2500" per scheme
defined in file ethernet-controller.yaml.

Correct phy-connection-type value should be "2500base-x".

Signed-off-by: Pali Rohár <pali@kernel.org>
Fixes: 84e0f1c13806 ("powerpc/mpc85xx: Add MDIO bus muxing support to the
board device tree(s)")
---
 arch/powerpc/boot/dts/fsl/t1023rdb.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/powerpc/boot/dts/fsl/t1023rdb.dts
b/arch/powerpc/boot/dts/fsl/t1023rdb.dts
index 5ba6fbfca274..f82f85c65964 100644
--- a/arch/powerpc/boot/dts/fsl/t1023rdb.dts
+++ b/arch/powerpc/boot/dts/fsl/t1023rdb.dts
@@ -154,7 +154,7 @@
 
                        fm1mac3: ethernet@e4000 {
                                phy-handle = <&sgmii_aqr_phy3>;
-                               phy-connection-type = "sgmii-2500";
+                               phy-connection-type = "2500base-x";
                                sleep = <&rcpm 0x20000000>;
                        };
 
Acked-by: Scott Wood <oss@buserror.net>

-Scott
Hello! If there is not any objection, could you take this patch?
Hello! I would like to remind this patch.
Hi Pali

I suggest you resend, and with To: Michael Ellerman [off-list ref]
to make it clear who you expect to pick up the
patch. Michael seems to do the Maintainer work in
arch/powerpc/boot/dts/

	Andrew
Done: https://lore.kernel.org/lkml/20211002090409.3833-1-pali@kernel.org/T/#u (local)
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help