Thread (4 messages) 4 messages, 4 authors, 2021-10-28

Re: [PATCH net-next v2] net: virtio: use eth_hw_addr_set()

flat view

From: patchwork-bot+netdevbpf@kernel.org
Date: 2021-10-28 15:20:08

Hello:

This patch was applied to netdev/net-next.git (master)
by Jakub Kicinski [off-list ref]:

On Wed, 27 Oct 2021 08:20:12 -0700 you wrote:
Commit 406f42fa0d3c ("net-next: When a bond have a massive amount
of VLANs...") introduced a rbtree for faster Ethernet address look
up. To maintain netdev->dev_addr in this tree we need to make all
the writes to it go through appropriate helpers.

Even though the current code uses dev->addr_len the we can switch
to eth_hw_addr_set() instead of dev_addr_set(). The netdev is
always allocated by alloc_etherdev_mq() and there are at least two
places which assume Ethernet address:
 - the line below calling eth_hw_addr_random()
 - virtnet_set_mac_address() -> eth_commit_mac_addr_change()

[...]
Here is the summary with links:
  - [net-next,v2] net: virtio: use eth_hw_addr_set()
    https://git.kernel.org/netdev/net-next/c/f2edaa4ad5d5

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help