Hi Jeremy,

I love your patch! Perhaps something to improve:

[auto build test WARNING on net-next/master]

url:    https://github.com/0day-ci/linux/commits/Jeremy-Kerr/mctp-Return-new-key-from-mctp_alloc_local_tag/20211028-142024
base:   https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git 5a48585d7ec1d0e1e83539d56846c1e513ef66ea
config: hexagon-randconfig-r041-20211027 (attached as .config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project 5db7568a6a1fcb408eb8988abdaff2a225a8eb72)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/27aeac2b7b2395816e26dcd1c3f3a1da4ae89ffe
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Jeremy-Kerr/mctp-Return-new-key-from-mctp_alloc_local_tag/20211028-142024
        git checkout 27aeac2b7b2395816e26dcd1c3f3a1da4ae89ffe
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 ARCH=hexagon 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <redacted>

All warnings (new ones prefixed by >>):

   In file included from net/mctp/test/utils.c:7:

quoted

include/net/mctpdevice.h:36:14: warning: declaration of 'struct mctp_sk_key' will not be visible outside of this function [-Wvisibility]

                                                   struct mctp_sk_key *key);
                                                          ^
   include/net/mctpdevice.h:51:52: warning: declaration of 'struct mctp_sk_key' will not be visible outside of this function [-Wvisibility]
   void mctp_dev_set_key(struct mctp_dev *dev, struct mctp_sk_key *key);
                                                      ^
   include/net/mctpdevice.h:52:56: warning: declaration of 'struct mctp_sk_key' will not be visible outside of this function [-Wvisibility]
   void mctp_dev_release_key(struct mctp_dev *dev, struct mctp_sk_key *key);
                                                          ^
   3 warnings generated.


vim +36 include/net/mctpdevice.h

    33	
    34	struct mctp_netdev_ops {
    35		void			(*release_flow)(struct mctp_dev *dev,
  > 36							struct mctp_sk_key *key);
    37	};
    38	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org