Re: [PATCH] net: phy: Fix unsigned comparison with less than zero
From: Jakub Kicinski <kuba@kernel.org>
Date: 2021-10-28 01:29:38
On Wed, 27 Oct 2021 16:59:51 +0800 Jiapeng Chong wrote:
Fix the following coccicheck warning:
./drivers/net/phy/at803x.c:493:5-10: WARNING: Unsigned expression
compared with zero: value < 0.
Reported-by: Abaci Robot <redacted>
Fixes: ea13c9ee855c ("drivers: net: phy: at803x: separate wol specific code to wol standard apis")
Please pay more attention.
This is not a correct fixes tag, take a look at the code, the
comparison was introduced in 7beecaf7d507 ("net: phy: at803x: improve
the WOL feature").
Do not fix spelling of the quoted commits. You replaced seperate
with separate and I had fun time trying to figure out why scripts
complain that the fixes tag is incorrect.
Fixed and applied to net-next.