Re: [PATCH ethtool 2/2] netlink: settings: Drop port filter for MDI-X
From: Michal Kubecek <hidden>
Date: 2021-10-27 20:17:34
On Wed, Oct 27, 2021 at 09:59:23PM +0200, Michal Kubecek wrote:
How about replacing "port == PORT_TP" with (port == TP || mdix != ETH_TP_MDI_INVALID || mdix_ctrl != ETH_TP_MDI_INVALID) in both code path and probably moving the check into dump_mdix()?
Looking at the code again, we cannot move the check into dump_mdix() easily as decision if print_banner(nlctx) should be called depends on its result. Michal
Attachments
- signature.asc [application/pgp-signature] 488 bytes