Thread (7 messages) flat view 7 messages, 2 authors, 2021-10-27

RE: [PATCH net-next] net: phy: microchip_t1: add cable test support for lan87xx phy

From: <hidden>
Date: 2021-10-27 14:22:53

-----Original Message-----
From: Andrew Lunn <andrew@lunn.ch>
Sent: Friday, October 22, 2021 3:48 PM
To: Yuiko Oshino - C18177 <redacted>
Cc: davem@davemloft.net; netdev@vger.kernel.org; Nisar Sayed - I17970
[off-list ref]; UNGLinuxDriver
[off-list ref]
Subject: Re: [PATCH net-next] net: phy: microchip_t1: add cable test support for
lan87xx phy

EXTERNAL EMAIL: Do not click links or open attachments unless you know the
content is safe
quoted
+/* MISC Control 1 Register */
+#define LAN87XX_CTRL_1                          (0x11)
+#define LAN87XX_MASK_RGMII_TXC_DLY_EN           (0x4000)
+#define LAN87XX_MASK_RGMII_RXC_DLY_EN           (0x2000)
Interesting to know, but not used in this patch.

Please can you write a patch to actually make use of these bits, and do the right
thing when phydev->interface is one of the four PHY_INTERFACE_MODE_RGMII
values.

        Andrew
Thank you, Andrew.
We will consider to make a use of these in another patch.
Yuiko
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help