Thread (7 messages) flat view 7 messages, 5 authors, 2021-10-26

Re: [PATCH net-next] net/mlx5: remove the recent devlink params

From: Jakub Kicinski <kuba@kernel.org>
Date: 2021-10-26 16:48:02

On Tue, 26 Oct 2021 19:45:10 +0300 Leon Romanovsky wrote:
On Tue, Oct 26, 2021 at 08:29:39AM -0700, Jakub Kicinski wrote:
quoted
revert commit 46ae40b94d88 ("net/mlx5: Let user configure io_eq_size param")
revert commit a6cb08daa3b4 ("net/mlx5: Let user configure event_eq_size param")
revert commit 554604061979 ("net/mlx5: Let user configure max_macs param")

The EQE parameters are applicable to more drivers, they should
be configured via standard API, probably ethtool. Example of
another driver needing something similar:

https://lore.kernel.org/all/1633454136-14679-3-git-send-email-sbhatta@marvell.com/ (local)

The last param for "max_macs" is probably fine but the documentation
is severely lacking. The meaning and implications for changing the
param need to be stated.

Signed-off-by: Jakub Kicinski <kuba@kernel.org>

LocalWords:  EQE param  
Your emacs config sneaked out.
I know, sorry, removed when applying.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help