Re: [PATCH] net/tls: Fix flipped sign in tls_err_abort() calls

On Thu, Oct 21, 2021 at 03:16:03PM -0700, Jakub Kicinski wrote:

Looks good to me

Thanks for looking.

the WARN_ON_ONCE() may be a little heavy and fire
multiple times, but hopefully compiler will do a good enough job on
removing it from places where the argument can't be positive.

True, well we could uninline tls_err_abort() since it should always be a
slow path.  I'm kinda inclined to do that absent other opinions.

We should probably also fix this assignment:

			ctx->async_wait.err = sk->sk_err;

I think async_wait.err is expected to have a negative errno.

But that can be a separate patch.

Oh yeah, that does look wrong, I'll send it in the next version.