Re: [PATCH net-next v2 12/12] net: hldc_fr: use dev_addr_set()
From: Krzysztof Hałasa <khalasa@piap.pl>
Date: 2021-10-22 06:22:14
Jakub Kicinski [off-list ref] writes:
Commit 406f42fa0d3c ("net-next: When a bond have a massive amount
of VLANs...") introduced a rbtree for faster Ethernet address look
up. To maintain netdev->dev_addr in this tree we need to make all
the writes to it got through appropriate helpers.
Signed-off-by: Jakub Kicinski <kuba@kernel.org>Acked-by: Krzysztof Hałasa <khalasa@piap.pl>
quoted hunk ↗ jump to hunk
--- a/drivers/net/wan/hdlc_fr.c +++ b/drivers/net/wan/hdlc_fr.c@@ -1093,7 +1093,9 @@ static int fr_add_pvc(struct net_device *frad, unsigned int dlci, int type) dev->priv_flags &= ~IFF_TX_SKB_SHARING; eth_hw_addr_random(dev); } else { - *(__be16 *)dev->dev_addr = htons(dlci); + __be16 addr = htons(dlci); + + dev_addr_set(dev, (u8 *)&addr); dlci_to_q922(dev->broadcast, dlci); } dev->netdev_ops = &pvc_ops;
-- Krzysztof "Chris" Hałasa Sieć Badawcza Łukasiewicz Przemysłowy Instytut Automatyki i Pomiarów PIAP Al. Jerozolimskie 202, 02-486 Warszawa