RE: [EXT] [PATCH net-next v2 1/2] net: qed_ptp: fix redundant check of rc and against -EINVAL

-----Original Message-----
From: Jεan Sacren <redacted>
Sent: Friday, October 22, 2021 9:08 AM
To: Ariel Elior <redacted>
Cc: GR-everest-linux-l2 <redacted>;
davem@davemloft.net; kuba@kernel.org; netdev@vger.kernel.org
Subject: [EXT] [PATCH net-next v2 1/2] net: qed_ptp: fix redundant check of rc
and against -EINVAL

External Email

----------------------------------------------------------------------
From: Jean Sacren <redacted>

We should first check rc alone and then check it against -EINVAL to
avoid repeating the same operation.

We should also remove the check of !rc in (!rc && !params.b_granted)
since it is always true.

With this change, we could also use constant 0 for return.

Signed-off-by: Jean Sacren <redacted>
Reviewed-by: Simon Horman <horms@kernel.org>
---

Acked-by: Prabhakar Kushwaha <redacted>