Re: [PATCH net-next 1/2] net: sched: fix logic error in qdisc_run_begin()
From: Eric Dumazet <edumazet@google.com>
Date: 2021-10-21 16:24:53
On Thu, Oct 21, 2021 at 9:23 AM Eric Dumazet [off-list ref] wrote:
From: Eric Dumazet <edumazet@google.com>
For non TCQ_F_NOLOCK qdisc, qdisc_run_begin() tries to set
__QDISC_STATE_RUNNING and should return true if the bit was not set.
test_and_set_bit() returns old bit value, therefore we need to invert.
Fixes: 29cbcd858283 ("net: sched: Remove Qdisc::running sequence counter")
Signed-off-by: Eric Dumazet <edumazet@google.com>
Cc: Ahmed S. Darwish <redacted>
Cc: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
---Please disregard, I have accidentally resent this already merged patch.