Thread (6 messages) flat view 6 messages, 3 authors, 2021-10-20

Re: [PATCH net-next v2] fq_codel: generalise ce_threshold marking for subset of traffic

From: patchwork-bot+netdevbpf@kernel.org
Date: 2021-10-20 23:40:08

Hello:

This patch was applied to netdev/net-next.git (master)
by Jakub Kicinski [off-list ref]:

On Tue, 19 Oct 2021 19:47:09 +0200 you wrote:
The commit in the Fixes tag expanded the ce_threshold feature of FQ-CoDel
so it can be applied to a subset of the traffic, using the ECT(1) bit of
the ECN field as the classifier. However, hard-coding ECT(1) as the only
classifier for this feature seems limiting, so let's expand it to be more
general.

To this end, change the parameter from a ce_threshold_ect1 boolean, to a
one-byte selector/mask pair (ce_threshold_{selector,mask}) which is applied
to the whole diffserv/ECN field in the IP header. This makes it possible to
classify packets by any value in either the ECN field or the diffserv
field. In particular, setting a selector of INET_ECN_ECT_1 and a mask of
INET_ECN_MASK corresponds to the functionality before this patch, and a
mask of ~INET_ECN_MASK allows using the selector as a straight-forward
match against a diffserv code point:

[...]
Here is the summary with links:
  - [net-next,v2] fq_codel: generalise ce_threshold marking for subset of traffic
    https://git.kernel.org/netdev/net-next/c/dfcb63ce1de6

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help