[PATCH net] net: enetc: fix ethtool counter name for PM0_TERR

Subsystems: freescale enetc ethernet drivers, networking drivers, the rest

STALE1763d LANDED

Landed in mainline as fb8dc5fc8cbd on 2021-10-21.

3 messages, 3 authors, 2021-10-21 · open the first message on its own page

[PATCH net] net: enetc: fix ethtool counter name for PM0_TERR

From: Vladimir Oltean <vladimir.oltean@nxp.com>
Date: 2021-10-20 16:52:20

There are two counters named "MAC tx frames", one of them is actually
incorrect. The correct name for that counter should be "MAC tx error
frames", which is symmetric to the existing "MAC rx error frames".

Fixes: 16eb4c85c964 ("enetc: Add ethtool statistics")
Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
---
 drivers/net/ethernet/freescale/enetc/enetc_ethtool.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/freescale/enetc/enetc_ethtool.c b/drivers/net/ethernet/freescale/enetc/enetc_ethtool.c
index 9690e36e9e85..910b9f722504 100644
--- a/drivers/net/ethernet/freescale/enetc/enetc_ethtool.c
+++ b/drivers/net/ethernet/freescale/enetc/enetc_ethtool.c
@@ -157,7 +157,7 @@ static const struct {
 	{ ENETC_PM0_TFRM,   "MAC tx frames" },
 	{ ENETC_PM0_TFCS,   "MAC tx fcs errors" },
 	{ ENETC_PM0_TVLAN,  "MAC tx VLAN frames" },
-	{ ENETC_PM0_TERR,   "MAC tx frames" },
+	{ ENETC_PM0_TERR,   "MAC tx frame errors" },
 	{ ENETC_PM0_TUCA,   "MAC tx unicast frames" },
 	{ ENETC_PM0_TMCA,   "MAC tx multicast frames" },
 	{ ENETC_PM0_TBCA,   "MAC tx broadcast frames" },
-- 
2.25.1

RE: [PATCH net] net: enetc: fix ethtool counter name for PM0_TERR

From: Claudiu Manoil <claudiu.manoil@nxp.com>
Date: 2021-10-21 09:37:26

-----Original Message-----
From: Vladimir Oltean <vladimir.oltean@nxp.com>
Sent: Wednesday, October 20, 2021 7:52 PM
[...]
Subject: [PATCH net] net: enetc: fix ethtool counter name for PM0_TERR

There are two counters named "MAC tx frames", one of them is actually
incorrect. The correct name for that counter should be "MAC tx error
frames", which is symmetric to the existing "MAC rx error frames".

Fixes: 16eb4c85c964 ("enetc: Add ethtool statistics")
Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
---
Reviewed-by: <Claudiu Manoil <claudiu.manoil@nxp.com>

Re: [PATCH net] net: enetc: fix ethtool counter name for PM0_TERR

From: patchwork-bot+netdevbpf@kernel.org
Date: 2021-10-21 15:10:10

Hello:

This patch was applied to netdev/net.git (master)
by Jakub Kicinski [off-list ref]:

On Wed, 20 Oct 2021 19:52:06 +0300 you wrote:
There are two counters named "MAC tx frames", one of them is actually
incorrect. The correct name for that counter should be "MAC tx error
frames", which is symmetric to the existing "MAC rx error frames".

Fixes: 16eb4c85c964 ("enetc: Add ethtool statistics")
Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>

[...]
Here is the summary with links:
  - [net] net: enetc: fix ethtool counter name for PM0_TERR
    https://git.kernel.org/netdev/net/c/fb8dc5fc8cbd

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help