Re: [PATCH net-next 5/5] net: mscc: ocelot: track the port pvid using a pointer

On Wed, 20 Oct 2021 13:56:02 +0300 Vladimir Oltean wrote:

Now that we have a list of struct ocelot_bridge_vlan entries, we can
rewrite the pvid logic to simply point to one of those structures,
instead of having a separate structure with a "bool valid".
The NULL pointer will represent the lack of a bridge pvid (not to be
confused with the lack of a hardware pvid on the port, that is present
at all times).

drivers/net/ethernet/mscc/ocelot_mrp.c: In function ‘ocelot_mrp_save_mac’:
drivers/net/ethernet/mscc/ocelot_mrp.c:119:21: error: ‘port->pvid_vlan’ is a pointer; did you mean to use ‘->’?
  119 |      port->pvid_vlan.vid, ENTRYTYPE_LOCKED);
      |                     ^
      |                     ->
drivers/net/ethernet/mscc/ocelot_mrp.c:121:21: error: ‘port->pvid_vlan’ is a pointer; did you mean to use ‘->’?
  121 |      port->pvid_vlan.vid, ENTRYTYPE_LOCKED);
      |                     ^
      |                     ->
drivers/net/ethernet/mscc/ocelot_mrp.c: In function ‘ocelot_mrp_del_mac’:
drivers/net/ethernet/mscc/ocelot_mrp.c:127:59: error: ‘port->pvid_vlan’ is a pointer; did you mean to use ‘->’?
  127 |  ocelot_mact_forget(ocelot, mrp_test_dmac, port->pvid_vlan.vid);
      |                                                           ^
      |                                                           ->
drivers/net/ethernet/mscc/ocelot_mrp.c:128:62: error: ‘port->pvid_vlan’ is a pointer; did you mean to use ‘->’?
  128 |  ocelot_mact_forget(ocelot, mrp_control_dmac, port->pvid_vlan.vid);
      |                                                              ^
      |                                                              ->
make[5]: *** [drivers/net/ethernet/mscc/ocelot_mrp.o] Error 1
make[5]: *** Waiting for unfinished jobs....
make[4]: *** [drivers/net/ethernet/mscc] Error 2
make[3]: *** [drivers/net/ethernet] Error 2
make[3]: *** Waiting for unfinished jobs....
make[2]: *** [drivers/net] Error 2
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [drivers] Error 2
make[1]: *** Waiting for unfinished jobs....
make: *** [__sub-make] Error 2