Re: [PATCH net-next] fq_codel: generalise ce_threshold marking for subset of traffic

Eric Dumazet [off-list ref] writes:

On Tue, Oct 19, 2021 at 10:17 AM Toke Høiland-Jørgensen [off-list ref] wrote:

quoted

The commit in the Fixes tag expanded the ce_threshold feature of FQ-CoDel
so it can be applied to a subset of the traffic, using the ECT(1) bit of
the ECN field as the classifier. However, hard-coding ECT(1) as the only
classifier for this feature seems limiting, so let's expand it to be more
general.

To this end, change the parameter from a ce_threshold_ect1 boolean, to a
one-byte selector/mask pair (ce_threshold_{selector,mask}) which is applied
to the whole diffserv/ECN field in the IP header. This makes it possible to
classify packets by any value in either the ECN field or the diffserv
field. In particular, setting a selector of INET_ECN_ECT_1 and a mask of
INET_ECN_MASK corresponds to the functionality before this patch, and a
mask of ~INET_ECN_MASK allows using the selector as a straight-forward
match against a diffserv code point.

Please include what command line should be used once we get iproute2
support.

Sure, will add that and send a v2

-Toke