Re: [Intel-wired-lan] [PATCH 1/1] ice: compact the file ice_nvm.c

Dear Yanjun,


Am 18.10.21 um 16:00 schrieb Yanjun Zhu:

在 2021/10/18 21:44, Paul Menzel 写道:

quoted

Am 18.10.21 um 15:17 schrieb yanjun.zhu@linux.dev:

quoted

From: Zhu Yanjun <redacted>

The function ice_aq_nvm_update_empr is not used, so remove it.

Thank you for the patch. Could you please make the commit message 
summary more descriptive? Maybe:

quoted

ice: Remove unused `ice_aq_nvm_update_empr()`

If you find out, what commit removed the usage, that would be also 
good to document, but it’s not that important.

Thanks for your suggestion.

IMO, removing the unused function is one method of compact file.

I agree with you that the commit message summary is not important.

Sorry, you misunderstood me. The commit message summary is my opinion 
very important, as it’s what shown in `git log --oneline`, and in this 
case everybody has to read the full commit message to know what the 
commit actually as *compact* is not conveying this meaning and is ambiguous.

Not as important is finding the commit removing the last user, and 
adding a Fixes tag with it.

If someone finds more important problem in this commit, I will resend the

patch and change the commit message summary based on your suggestion.

It’d be great, if you sent an improved version.


Kind regards,

Paul