[PATCH 1/1] ice: compact the file ice_nvm.c

From: Zhu Yanjun <redacted>

The function ice_aq_nvm_update_empr is not used, so remove it.

Signed-off-by: Zhu Yanjun <redacted>
---
 drivers/net/ethernet/intel/ice/ice_nvm.c | 16 ----------------
 drivers/net/ethernet/intel/ice/ice_nvm.h |  1 -
 2 files changed, 17 deletions(-)

diff --git a/drivers/net/ethernet/intel/ice/ice_nvm.c b/drivers/net/ethernet/intel/ice/ice_nvm.c
index fee37a5844cf..bad374bd7ab3 100644
--- a/drivers/net/ethernet/intel/ice/ice_nvm.c
+++ b/drivers/net/ethernet/intel/ice/ice_nvm.c

@@ -1106,22 +1106,6 @@ enum ice_status ice_nvm_write_activate(struct ice_hw *hw, u8 cmd_flags)
 	return ice_aq_send_cmd(hw, &desc, NULL, 0, NULL);
 }
 
-/**
- * ice_aq_nvm_update_empr
- * @hw: pointer to the HW struct
- *
- * Update empr (0x0709). This command allows SW to
- * request an EMPR to activate new FW.
- */
-enum ice_status ice_aq_nvm_update_empr(struct ice_hw *hw)
-{
-	struct ice_aq_desc desc;
-
-	ice_fill_dflt_direct_cmd_desc(&desc, ice_aqc_opc_nvm_update_empr);
-
-	return ice_aq_send_cmd(hw, &desc, NULL, 0, NULL);
-}
-
 /* ice_nvm_set_pkg_data
  * @hw: pointer to the HW struct
  * @del_pkg_data_flag: If is set then the current pkg_data store by FW

diff --git a/drivers/net/ethernet/intel/ice/ice_nvm.h b/drivers/net/ethernet/intel/ice/ice_nvm.h
index c6f05f43d593..925225905491 100644
--- a/drivers/net/ethernet/intel/ice/ice_nvm.h
+++ b/drivers/net/ethernet/intel/ice/ice_nvm.h

@@ -39,7 +39,6 @@ enum ice_status
 ice_aq_erase_nvm(struct ice_hw *hw, u16 module_typeid, struct ice_sq_cd *cd);
 enum ice_status ice_nvm_validate_checksum(struct ice_hw *hw);
 enum ice_status ice_nvm_write_activate(struct ice_hw *hw, u8 cmd_flags);
-enum ice_status ice_aq_nvm_update_empr(struct ice_hw *hw);
 enum ice_status
 ice_nvm_set_pkg_data(struct ice_hw *hw, bool del_pkg_data_flag, u8 *data,
 		     u16 length, struct ice_sq_cd *cd);

-- 
2.27.0

Dear Yanjun,


Am 18.10.21 um 15:17 schrieb yanjun.zhu@linux.dev:

From: Zhu Yanjun <redacted>

The function ice_aq_nvm_update_empr is not used, so remove it.

Thank you for the patch. Could you please make the commit message 
summary more descriptive? Maybe:

ice: Remove unused `ice_aq_nvm_update_empr()`

If you find out, what commit removed the usage, that would be also good 
to document, but it’s not that important.


Kind regards,

Paul

Dear Yanjun,


Am 18.10.21 um 16:00 schrieb Yanjun Zhu:

在 2021/10/18 21:44, Paul Menzel 写道:

quoted

Am 18.10.21 um 15:17 schrieb yanjun.zhu@linux.dev:

quoted

From: Zhu Yanjun <redacted>

The function ice_aq_nvm_update_empr is not used, so remove it.

Thank you for the patch. Could you please make the commit message 
summary more descriptive? Maybe:

quoted

ice: Remove unused `ice_aq_nvm_update_empr()`

If you find out, what commit removed the usage, that would be also 
good to document, but it’s not that important.

Thanks for your suggestion.

IMO, removing the unused function is one method of compact file.

I agree with you that the commit message summary is not important.

Sorry, you misunderstood me. The commit message summary is my opinion 
very important, as it’s what shown in `git log --oneline`, and in this 
case everybody has to read the full commit message to know what the 
commit actually as *compact* is not conveying this meaning and is ambiguous.

Not as important is finding the commit removing the last user, and 
adding a Fixes tag with it.

If someone finds more important problem in this commit, I will resend the

patch and change the commit message summary based on your suggestion.

It’d be great, if you sent an improved version.


Kind regards,

Paul

在 2021/10/18 21:44, Paul Menzel 写道:

Dear Yanjun,


Am 18.10.21 um 15:17 schrieb yanjun.zhu@linux.dev:

quoted

From: Zhu Yanjun <redacted>

The function ice_aq_nvm_update_empr is not used, so remove it.

Thank you for the patch. Could you please make the commit message 
summary more descriptive? Maybe:

quoted

ice: Remove unused `ice_aq_nvm_update_empr()`

If you find out, what commit removed the usage, that would be also 
good to document, but it’s not that important.

Thanks for your suggestion.

IMO, removing the unused function is one method of compact file.

I agree with you that the commit message summary is not important.

If someone finds more important problem in this commit, I will resend the

patch and change the commit message summary based on your suggestion.


Best Regards.

Zhu Yanjun

Kind regards,

Paul

quoted

Signed-off-by: Zhu Yanjun <redacted>
---
  drivers/net/ethernet/intel/ice/ice_nvm.c | 16 ----------------
  drivers/net/ethernet/intel/ice/ice_nvm.h |  1 -
  2 files changed, 17 deletions(-)

diff --git a/drivers/net/ethernet/intel/ice/ice_nvm.c 

b/drivers/net/ethernet/intel/ice/ice_nvm.c
index fee37a5844cf..bad374bd7ab3 100644

--- a/drivers/net/ethernet/intel/ice/ice_nvm.c
+++ b/drivers/net/ethernet/intel/ice/ice_nvm.c

@@ -1106,22 +1106,6 @@ enum ice_status ice_nvm_write_activate(struct 

ice_hw *hw, u8 cmd_flags)
      return ice_aq_send_cmd(hw, &desc, NULL, 0, NULL);
  }
  -/**
- * ice_aq_nvm_update_empr
- * @hw: pointer to the HW struct
- *
- * Update empr (0x0709). This command allows SW to
- * request an EMPR to activate new FW.
- */
-enum ice_status ice_aq_nvm_update_empr(struct ice_hw *hw)
-{
-    struct ice_aq_desc desc;
-
-    ice_fill_dflt_direct_cmd_desc(&desc, ice_aqc_opc_nvm_update_empr);
-
-    return ice_aq_send_cmd(hw, &desc, NULL, 0, NULL);
-}
-
  /* ice_nvm_set_pkg_data
   * @hw: pointer to the HW struct
   * @del_pkg_data_flag: If is set then the current pkg_data store by FW

diff --git a/drivers/net/ethernet/intel/ice/ice_nvm.h 

b/drivers/net/ethernet/intel/ice/ice_nvm.h
index c6f05f43d593..925225905491 100644

--- a/drivers/net/ethernet/intel/ice/ice_nvm.h
+++ b/drivers/net/ethernet/intel/ice/ice_nvm.h

@@ -39,7 +39,6 @@ enum ice_status

  ice_aq_erase_nvm(struct ice_hw *hw, u16 module_typeid, struct 
ice_sq_cd *cd);
  enum ice_status ice_nvm_validate_checksum(struct ice_hw *hw);
  enum ice_status ice_nvm_write_activate(struct ice_hw *hw, u8 
cmd_flags);
-enum ice_status ice_aq_nvm_update_empr(struct ice_hw *hw);
  enum ice_status
  ice_nvm_set_pkg_data(struct ice_hw *hw, bool del_pkg_data_flag, u8 
*data,
               u16 length, struct ice_sq_cd *cd);

在 2021/10/18 22:05, Paul Menzel 写道:

Dear Yanjun,


Am 18.10.21 um 16:00 schrieb Yanjun Zhu:

quoted

在 2021/10/18 21:44, Paul Menzel 写道:

quoted

quoted

Am 18.10.21 um 15:17 schrieb yanjun.zhu@linux.dev:

quoted

From: Zhu Yanjun <redacted>

The function ice_aq_nvm_update_empr is not used, so remove it.

Thank you for the patch. Could you please make the commit message 
summary more descriptive? Maybe:

quoted

ice: Remove unused `ice_aq_nvm_update_empr()`

If you find out, what commit removed the usage, that would be also 
good to document, but it’s not that important.

Thanks for your suggestion.

IMO, removing the unused function is one method of compact file.

I agree with you that the commit message summary is not important.

Sorry, you misunderstood me. The commit message summary is my opinion 
very important, as it’s what shown in `git log --oneline`, and in this 
case everybody has to read the full commit message to know what the 
commit actually as *compact* is not conveying this meaning and is 
ambiguous.

Not as important is finding the commit removing the last user, and 
adding a Fixes tag with it.

Got it.

quoted

If someone finds more important problem in this commit, I will resend 
the

patch and change the commit message summary based on your suggestion.

It’d be great, if you sent an improved version.

I will resend the latest version.

Zhu Yanjun

Kind regards,

Paul