Thread (23 messages) flat view 23 messages, 4 authors, 2021-10-16

Re: [PATCH net-next v4 04/15] mctp: Add sockaddr_mctp to uapi

From: Jeremy Kerr <jk@codeconstruct.com.au>
Date: 2021-10-16 02:13:06

Hi Eugene,
On Thu, Jul 29, 2021 at 10:20:42AM +0800, Jeremy Kerr wrote:
quoted
 struct sockaddr_mctp {
+       unsigned short int      smctp_family;
+       int                     smctp_network;
struct mctp_skb_cb.net (as well as struct mctp_dev.net) are unsigned,
is it intentional that this field (along with struct
mctp_sock.bind_net) differs in signedness?
No, that's not intentional - I'll submit a patch to unify those.

Thanks for the review.

Cheers,


Jeremy


Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help