Re: [PATCH net-next v4 10/15] net: bridge: mcast: support for IGMPv3/MLDv2 ALLOW_NEW_SOURCES report
From: Hangbin Liu <hidden>
Date: 2021-10-15 06:37:08
Also in:
bridge
From: Hangbin Liu <hidden>
Date: 2021-10-15 06:37:08
Also in:
bridge
On Fri, Oct 15, 2021 at 10:52:00AM +0800, Hangbin Liu wrote:
quoted
- mod_timer(&p->timer, now + br->multicast_membership_interval); + if (igmpv2_mldv1) + mod_timer(&p->timer, now + br->multicast_membership_interval);Hi Nikolay, Our engineer found that the multicast_membership_interval will not work with IGMPv3. Is it intend as you said "IGMPv3/MLDv2 handling is not yet implemented" ?
Ah, I saw in br_multicast_group_expired() it wait for mp->ports be freed before delete the mdb entry. And in br_multicast_port_group_expired() it wait for src entry freed first. But when mod group src timer, we use __grp_src_mod_timer(ent, now + br_multicast_gmi(brmctx)); instead of user configured multicast_membership_interval. I think we should fix it. WDYT? Thanks Hangbin