Re: [PATCH iproute2 v5 7/7] configure: add the --libdir option
From: Phil Sutter <phil@nwl.cc>
Date: 2021-10-14 10:10:58
Hi Andrea, On Thu, Oct 14, 2021 at 10:50:55AM +0200, Andrea Claudi wrote: [...]
quoted hunk ↗ jump to hunk
diff --git a/Makefile b/Makefile index 5eddd504..f6214534 100644 --- a/Makefile +++ b/Makefile@@ -1,6 +1,8 @@ # SPDX-License-Identifier: GPL-2.0 # Top level Makefile for iproute2 +-include config.mk +
Assuming config.mk may be missing (as dash-prefix is used).
quoted hunk ↗ jump to hunk
ifeq ("$(origin V)", "command line") VERBOSE = $(V) endif@@ -13,7 +15,6 @@ MAKEFLAGS += --no-print-directory endif PREFIX?=/usr -LIBDIR?=$(PREFIX)/lib
Dropping this leads to trouble if config.mk is missing or didn't define it. Can't you just leave it in place? Usually config.mk would override it anyway, no? Rest of the series looks great, thanks a lot for spending the extra cycles giving it the mirror finish it has now. :) Cheers, Phil