Thread (2 messages) flat view 2 messages, 2 authors, 2021-10-13

Re: [PATCH net-next] net: dsa: unregister cross-chip notifier after ds->ops->teardown

From: patchwork-bot+netdevbpf@kernel.org
Date: 2021-10-13 20:40:10

Hello:

This patch was applied to netdev/net-next.git (master)
by Jakub Kicinski [off-list ref]:

On Tue, 12 Oct 2021 15:37:35 +0300 you wrote:
To be symmetric with the error unwind path of dsa_switch_setup(), call
dsa_switch_unregister_notifier() after ds->ops->teardown.

The implication is that ds->ops->teardown cannot emit cross-chip
notifiers. For example, currently the dsa_tag_8021q_unregister() call
from sja1105_teardown() does not propagate to the entire tree due to
this reason. However I cannot find an actual issue caused by this,
observed using code inspection.

[...]
Here is the summary with links:
  - [net-next] net: dsa: unregister cross-chip notifier after ds->ops->teardown
    https://git.kernel.org/netdev/net-next/c/39e222bfd7f3

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help