Thread (2 messages) flat view 2 messages, 2 authors, 2021-10-12

Re: [net PATCH] ice: fix locking for Tx timestamp tracking flush

From: patchwork-bot+netdevbpf@kernel.org
Date: 2021-10-12 11:20:08

Hello:

This patch was applied to netdev/net.git (master)
by David S. Miller [off-list ref]:

On Mon, 11 Oct 2021 13:48:06 -0700 you wrote:
Commit 4dd0d5c33c3e ("ice: add lock around Tx timestamp tracker flush")
added a lock around the Tx timestamp tracker flow which is used to
cleanup any left over SKBs and prepare for device removal.

This lock is problematic because it is being held around a call to
ice_clear_phy_tstamp. The clear function takes a mutex to send a PHY
write command to firmware. This could lead to a deadlock if the mutex
actually sleeps, and causes the following warning on a kernel with
preemption debugging enabled:

[...]
Here is the summary with links:
  - [net] ice: fix locking for Tx timestamp tracking flush
    https://git.kernel.org/netdev/net/c/4d4a223a86af

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help