On Fri, 08 Oct 2021 19:35:11 -0700 Joe Perches wrote:

quoted

@@ -1821,8 +1823,7 @@ static void de21041_get_srom_info(struct de_private *de)

 #endif

 	/* store MAC address */
-	for (i = 0; i < 6; i ++)
-		de->dev->dev_addr[i] = ee_data[i + sa_offset];
+	eth_hw_addr_set(de->dev, &ee_data[i + sa_offset]);  

what is the content of i here?

Perhaps you want

	eth_hw_addr_set(de->dev, &ee_data[sa_offset]);

quoted

diff --git a/drivers/net/ethernet/dec/tulip/dmfe.c b/drivers/net/ethernet/dec/tulip/dmfe.c  

[]

quoted

@@ -476,8 +476,7 @@ static int dmfe_init_one(struct pci_dev *pdev, const struct pci_device_id *ent)

 	}
 

 	/* Set Node address */
-	for (i = 0; i < 6; i++)
-		dev->dev_addr[i] = db->srom[20 + i];
+	eth_hw_addr_set(dev, &db->srom[20 + i]);  

here too

Good catch, thanks.