Re: [PATCH net-next v4] net: ipvs: add sysctl_run_estimation to support disable estimation

On Sat, Oct 02, 2021 at 10:59:29AM +0200, Simon Horman wrote:

On Sat, Aug 21, 2021 at 11:41:50AM +0300, Julian Anastasov wrote:

quoted

	Hello,

On Fri, 20 Aug 2021, Dust Li wrote:

quoted

estimation_timer will iterate the est_list to do estimation
for each ipvs stats. When there are lots of services, the
list can be very large.
We found that estimation_timer() run for more then 200ms on a
machine with 104 CPU and 50K services.

yunhong-cgl jiang report the same phenomenon before:
https://www.spinics.net/lists/lvs-devel/msg05426.html

In some cases(for example a large K8S cluster with many ipvs services),
ipvs estimation may not be needed. So adding a sysctl blob to allow
users to disable this completely.

Default is: 1 (enable)

Cc: yunhong-cgl jiang <redacted>
Signed-off-by: Dust Li <dust.li@linux.alibaba.com>

	Looks good to me, thanks!

Acked-by: Julian Anastasov <ja@ssi.bg>

Likwewise, thanks. And sorry for the delay.

Acked-by: Simon Horman <horms@verge.net.au>

Pablo, could you consider picking this up?

Applied, thanks.