Re: [RFC] fwnode: change the return type of mac address helpers
From: Andrew Lunn <andrew@lunn.ch>
Date: 2021-10-06 14:49:41
quoted hunk ↗ jump to hunk
--- a/drivers/net/ethernet/apm/xgene-v2/main.c +++ b/drivers/net/ethernet/apm/xgene-v2/main.c@@ -36,7 +36,7 @@ static int xge_get_resources(struct xge_pdata *pdata) return -ENOMEM; } - if (!device_get_ethdev_addr(dev, ndev)) + if (device_get_ethdev_addr(dev, ndev)) eth_hw_addr_random(ndev);
That is going to be interesting for out of tree drivers. Otherwise, this looks O.K. Andrew