Re: [PATCH net] dsa: tag_dsa: Fix mask for trunked packets
From: Vladimir Oltean <vladimir.oltean@nxp.com>
Date: 2021-10-03 21:07:29
On Sun, Oct 03, 2021 at 05:50:53PM +0200, Andrew Lunn wrote:
A packet received on a trunk will have bit 2 set in Forward DSA tagged
frame. Bit 1 can be either 0 or 1 and is otherwise undefined and bit 0
indicates the frame CFI. Masking with 7 thus results in frames as
being identified as being from a trunk when in fact they are not. Fix
the mask to just look at bit 2.
Fixes: 5b60dadb71db ("net: dsa: tag_dsa: Support reception of packets from LAG devices")
Signed-off-by: Andrew Lunn <andrew@lunn.ch>
---Reviewed-by: Vladimir Oltean <vladimir.oltean@nxp.com> At least this appears correct on 88E6096/97, but I would expect it to be true for the entire family. Would like to hear Tobias' feedback too, though.