RE: [PATCH] can: rcar_can: Fix suspend/resume

Hi Simon-san,

From: Simon Horman, Sent: Thursday, September 23, 2021 12:24 AM

On Tue, Sep 21, 2021 at 12:38:13PM +0200, Ulrich Hecht wrote:

quoted

quoted

On 09/21/2021 7:19 AM Yoshihiro Shimoda [off-list ref] wrote:


If the driver was not opened, rcar_can_suspend() should not call
clk_disable() because the clock was not enabled.

Fixes: fd1159318e55 ("can: add Renesas R-Car CAN driver")
Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Tested-by: Ayumi Nakamichi <redacted>
---
 drivers/net/can/rcar/rcar_can.c | 21 +++++++++++++--------
 1 file changed, 13 insertions(+), 8 deletions(-)

diff --git a/drivers/net/can/rcar/rcar_can.c b/drivers/net/can/rcar/rcar_can.c
index 00e4533c8bdd..6b4eefb03044 100644
--- a/drivers/net/can/rcar/rcar_can.c
+++ b/drivers/net/can/rcar/rcar_can.c

...

quoted

quoted

@@ -858,6 +860,7 @@ static int __maybe_unused rcar_can_suspend(struct device *dev)
 	priv->can.state = CAN_STATE_SLEEPING;

 	clk_disable(priv->clk);
+
 	return 0;
 }

nit: this hunk seems unrelated to the rest of the patch

Thank you for your comment! I'll remove this.

Best regards,
Yoshihiro Shimda

...