Re: [PATCH v4 bpf-next 2/9] selftests/bpf: stop using bpf_program__load
From: Andrii Nakryiko <hidden>
Date: 2021-09-02 22:58:38
Also in:
bpf
From: Andrii Nakryiko <hidden>
Date: 2021-09-02 22:58:38
Also in:
bpf
On Thu, Sep 2, 2021 at 10:20 AM Dave Marchevsky [off-list ref] wrote:
bpf_program__load is not supposed to be used directly. Replace it with bpf_object__ APIs for the reference_tracking prog_test, which is the last offender in bpf selftests. Some additional complexity is added for this test, namely the use of one bpf_object to iterate through progs, while a second bpf_object is created and opened/closed to test actual loading of progs. This is because the test was doing bpf_program__load then __unload to test loading of individual progs and same semantics with bpf_object__load/__unload result in failure to load an __unload-ed obj. Signed-off-by: Dave Marchevsky <redacted> ---
LGTM. Acked-by: Andrii Nakryiko <andrii@kernel.org>
.../bpf/prog_tests/reference_tracking.c | 39 +++++++++++++++---- 1 file changed, 31 insertions(+), 8 deletions(-)
[...]