Re: [PATCH v2] rsi: Fix module dev_oper_mode parameter description
From: Kalle Valo <hidden>
Date: 2021-09-21 15:04:37
Also in:
linux-wireless, stable
Marek Vasut [off-list ref] wrote:
The module parameters are missing dev_oper_mode 12, BT classic alone,
add it. Moreover, the parameters encode newlines, which ends up being
printed malformed e.g. by modinfo, so fix that too.
However, the module parameter string is duplicated in both USB and SDIO
modules and the dev_oper_mode mode enumeration in those module parameters
is a duplicate of macros used by the driver. Furthermore, the enumeration
is confusing.
So, deduplicate the module parameter string and use __stringify() to
encode the correct mode enumeration values into the module parameter
string. Finally, replace 'Wi-Fi' with 'Wi-Fi alone' and 'BT' with
'BT classic alone' to clarify what those modes really mean.
Fixes: 898b255339310 ("rsi: add module parameter operating mode")
Signed-off-by: Marek Vasut <marex@denx.de>
Cc: Amitkumar Karwar <redacted>
Cc: Angus Ainslie <redacted>
Cc: David S. Miller <davem@davemloft.net>
Cc: Jakub Kicinski <kuba@kernel.org>
Cc: Kalle Valo <redacted>
Cc: Karun Eagalapati <redacted>
Cc: Martin Fuzzey <redacted>
Cc: Martin Kepplinger <martink@posteo.de>
Cc: Prameela Rani Garnepudi <redacted>
Cc: Sebastian Krzyszkowiak <sebastian.krzyszkowiak@puri.sm>
Cc: Siva Rebbagondla <redacted>
Cc: netdev@vger.kernel.org
Cc: <redacted> # 4.17+Patch applied to wireless-drivers-next.git, thanks. 31f97cf9f0c3 rsi: Fix module dev_oper_mode parameter description -- https://patchwork.kernel.org/project/linux-wireless/patch/20210916144245.10181-1-marex@denx.de/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches