Thread (3 messages) flat view 3 messages, 2 authors, 2021-09-16

Re: [PATCH] rsi: Fix module dev_oper_mode parameter description

From: Sebastian Krzyszkowiak <sebastian.krzyszkowiak@puri.sm>
Date: 2021-09-16 07:03:51
Also in: stable

On środa, 15 września 2021 10:08:41 CEST Marek Vasut wrote:
+#define DEV_OPMODE_PARAM_DESC		\
+	__stringify(DEV_OPMODE_WIFI_ALONE)	"[Wi-Fi alone], "	\
+	__stringify(DEV_OPMODE_BT_ALONE)	"[BT classic alone], "	\
+	__stringify(DEV_OPMODE_BT_LE_ALONE)	"[BT LE], "		
\
+	__stringify(DEV_OPMODE_BT_DUAL)		"[BT Dual], "		
\
+	__stringify(DEV_OPMODE_STA_BT)		"[Wi-Fi STA + BT 
classic], " \
+	__stringify(DEV_OPMODE_STA_BT_LE)	"[Wi-Fi STA + BT LE], "	\
+	__stringify(DEV_OPMODE_STA_BT_DUAL)	"[Wi-Fi STA + BT 
classic + BT LE], " \
+	__stringify(DEV_OPMODE_AP_BT)		"[AP + BT classic], "	
\
+	__stringify(DEV_OPMODE_AP_BT_DUAL)	"[AP + BT classic + BT LE]"
There's still some inconsistency in mode naming - how about: 

- Wi-Fi STA
- BT classic
- BT LE
- BT classic + BT LE
- Wi-Fi STA + BT classic
- Wi-Fi STA + BT LE
- Wi-Fi STA + BT classic + BT LE
- Wi-Fi AP + BT classic
- Wi-Fi AP + BT classic + BT LE

"alone" could be added to the first three modes (you missed it in BT LE).

Cheers,
Sebastian

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help