RE: [EXT] Re: [PATCH 04/12] qed: Update qed_mfw_hsi.h for FW ver 8.59.1.0

Thanks Jakub for reviewing this patch series. 

-----Original Message-----
From: Jakub Kicinski <kuba@kernel.org>
Sent: Thursday, September 30, 2021 12:08 AM
To: Prabhakar Kushwaha <redacted>
Cc: netdev@vger.kernel.org; davem@davemloft.net; linux-
rdma@vger.kernel.org; linux-scsi@vger.kernel.org;
martin.petersen@oracle.com; Ariel Elior [off-list ref]; Shai Malin
[off-list ref]; Javed Hasan [off-list ref]; Manish
Rangankar [off-list ref]; prabhakar.pkin@gmail.com;
malin1024@gmail.com; Omkar Kulkarni [off-list ref]
Subject: [EXT] Re: [PATCH 04/12] qed: Update qed_mfw_hsi.h for FW ver
8.59.1.0

On Wed, 29 Sep 2021 15:12:07 +0300 Prabhakar Kushwaha wrote:

quoted

The qed_mfw_hsi.h contains HSI (Hardware Software Interface) changes
related to management firmware. It has been updated to support new FW
version 8.59.1.0 with below changes.
 - New defines for VF bitmap.
 - fec_mode and extended_speed defines updated in struct eth_phy_cfg.
 - Updated structutres lldp_system_tlvs_buffer_s, public_global,
   public_port, public_func, drv_union_data, public_drv_mb
   with all dependent new structures.
 - Updates in NVM related structures and defines.
 - Msg defines are added in enum drv_msg_code and fw_msg_code.
 - Updated/added new defines.

This patch also fixes the existing checkpatch warnings and few important
checks.

Signed-off-by: Ariel Elior <redacted>
Signed-off-by: Omkar Kulkarni <redacted>
Signed-off-by: Shai Malin <redacted>
Signed-off-by: Prabhakar Kushwaha <redacted>

drivers/net/ethernet/qlogic/qed/qed_main.c:102:18: warning:
‘qed_mfw_ext_20g’ defined but not used [-Wunused-const-variable=]
  102 | static const u32 qed_mfw_ext_20g[] __initconst = {
      |                  ^~~~~~~~~~~~~~~


Plus you add a whole bunch on kdoc warnings with those patches.
Please make sure no new kdoc warnings and no new compilation warnings
(with C=1 W=1 flags!)

Sorry from our side. 

Let me fix this and share v2 for review. 

--pk