Re: [External] Re: Regression in unix stream sockets with the Smack LSM

On 9/29/2021 11:36 AM, Jiang Wang . wrote:

On Wed, Sep 29, 2021 at 8:44 AM Casey Schaufler [off-list ref] wrote:

quoted

On 9/20/2021 4:44 PM, Casey Schaufler wrote:

quoted

On 9/20/2021 3:35 PM, Jiang Wang . wrote:

quoted

On Wed, Sep 15, 2021 at 9:52 AM Casey Schaufler [off-list ref] wrote:

quoted

On 9/13/2021 4:47 PM, Paul Moore wrote:

quoted

On Mon, Sep 13, 2021 at 6:53 PM Casey Schaufler [off-list ref] wrote:

quoted

Commit 77462de14a43f4d98dbd8de0f5743a4e02450b1d

        af_unix: Add read_sock for stream socket types

introduced a regression in UDS socket connections for the Smack LSM.
I have not tracked done the details of why the change broke the code,
but this is where bisecting the kernel indicates the problem lies, and
I have verified that reverting this change repairs the problem.

You can verify the problem with the Smack test suite:

        https://github.com/smack-team/smack-testsuite.git

The failing test is tests/uds-access.sh.

I tried to reproduce with tests/uds-access.sh, but the first two test
cases always failed.

Just piping in that the behavior hasn't changed in 5.15-rc3.
It still usually fails, with the occasional success. These
tests used to succeed.

Got it. I am still working on it. I noticed that I did not enable smack
related kernel configs in my previous tests. I will try again.
Also, just to make sure, could you send me your kernel config?

I've attached both the fedora and ubuntu configuation files.
Enjoy.