On 9/28/21 13:59, Dan Carpenter wrote:

On Tue, Sep 28, 2021 at 01:46:56PM +0300, Pavel Skripkin wrote:

quoted

quoted

diff --git a/drivers/net/phy/mdio_bus.c b/drivers/net/phy/mdio_bus.c
index ee8313a4ac71..c380a30a77bc 100644
--- a/drivers/net/phy/mdio_bus.c
+++ b/drivers/net/phy/mdio_bus.c

@@ -538,6 +538,7 @@ int __mdiobus_register(struct mii_bus *bus, struct module *owner)
  	bus->dev.groups = NULL;
  	dev_set_name(&bus->dev, "%s", bus->id);
+	bus->state = MDIOBUS_UNREGISTERED;
  	err = device_register(&bus->dev);
  	if (err) {
  		pr_err("mii_bus %s failed to register\n", bus->id);

yep, it's the same as mine, but I thought, that MDIOBUS_UNREGISTERED is not
correct name for this state :) Anyway, thank you for suggestion

It's not actually the same.  The state has to be set before the
device_register() or there is still a leak.

Ah, I see... I forgot to handle possible device_register() error. Will 
send v2 soon, thank you



With regards,
Pavel Skripkin