Thread (32 messages) 32 messages, 7 authors, 2021-09-29

Re: [PATCH net-next v1 01/21] devlink: Notify users when objects are accessible

From: Leon Romanovsky <leon@kernel.org>
Date: 2021-09-28 07:35:07
Also in: intel-wired-lan, linux-omap, linux-rdma, linux-staging, lkml

On Mon, Sep 27, 2021 at 07:49:18PM -0700, Eric Dumazet wrote:

On 9/25/21 4:22 AM, Leon Romanovsky wrote:
quoted
From: Leon Romanovsky <leonro@nvidia.com>

The devlink core code notified users about add/remove objects without
relation if this object can be accessible or not. In this patch we unify
such user visible notifications in one place.

Signed-off-by: Leon Romanovsky <leonro@nvidia.com>
---
 net/core/devlink.c | 107 +++++++++++++++++++++++++++++++++++++++------
 1 file changed, 93 insertions(+), 14 deletions(-)
<...>
quoted
 static void devlink_rate_notify(struct devlink_rate *devlink_rate,
 				enum devlink_command cmd)
 {
+	struct devlink *devlink = devlink_rate->devlink;
 	struct sk_buff *msg;
 	int err;
 
 	WARN_ON(cmd != DEVLINK_CMD_RATE_NEW && cmd != DEVLINK_CMD_RATE_DEL);
+	WARN_ON(!xa_get_mark(&devlinks, devlink->index, DEVLINK_REGISTERED));

FYI, this new warning was triggered by syzbot :
Thanks for the report, it is combination of my rebase error and missing
loop of devlink_rate_notify in the devlink_notify_register() function.

I'll fix and resubmit.

Thanks
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help