Thread (4 messages) flat view 4 messages, 3 authors, 2021-09-27

RE: [PATCH] igc: fix PTP dependency

From: "Keller, Jacob E" <jacob.e.keller@intel.com>
Date: 2021-09-27 22:35:42
Also in: intel-wired-lan, lkml

-----Original Message-----
From: Arnd Bergmann <arnd@kernel.org>
Sent: Monday, September 27, 2021 6:17 AM
To: Brandeburg, Jesse <redacted>; Nguyen, Anthony L
[off-list ref]; David S. Miller [off-list ref]; Jakub
Kicinski [off-list ref]
Cc: Arnd Bergmann <arnd@arndb.de>; Keller, Jacob E
[off-list ref]; Saleem, Shiraz [off-list ref]; Kurt
Kanzenbach [off-list ref]; Ertman, David M
[off-list ref]; Shannon Nelson [off-list ref];
Richard Cochran [off-list ref]; Vladimir Oltean
[off-list ref]; intel-wired-lan@lists.osuosl.org;
netdev@vger.kernel.org; linux-kernel@vger.kernel.org
Subject: [PATCH] igc: fix PTP dependency

From: Arnd Bergmann <arnd@arndb.de>

The igc driver was accidentally left out of the Kconfig rework for PTP,
it needs the same dependency as the others:

arm-linux-gnueabi-ld: drivers/net/ethernet/intel/igc/igc_main.o: in function
`igc_tsync_interrupt':
igc_main.c:(.text+0x1b288): undefined reference to `ptp_clock_event'
arm-linux-gnueabi-ld: igc_main.c:(.text+0x1b308): undefined reference to
`ptp_clock_event'
arm-linux-gnueabi-ld: igc_main.c:(.text+0x1b8cc): undefined reference to
`ptp_clock_event'
arm-linux-gnueabi-ld: drivers/net/ethernet/intel/igc/igc_ethtool.o: in function
`igc_ethtool_get_ts_info':

Fixes: e5f31552674e ("ethernet: fix PTP_1588_CLOCK dependencies")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Thanks!

-Jake
quoted hunk ↗ jump to hunk
---
 drivers/net/ethernet/intel/Kconfig | 1 +
 1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/intel/Kconfig
b/drivers/net/ethernet/intel/Kconfig
index b0b6f90deb7d..ed8ea63bb172 100644
--- a/drivers/net/ethernet/intel/Kconfig
+++ b/drivers/net/ethernet/intel/Kconfig
@@ -335,6 +335,7 @@ config IGC
 	tristate "Intel(R) Ethernet Controller I225-LM/I225-V support"
 	default n
 	depends on PCI
+	depends on PTP_1588_CLOCK_OPTIONAL
 	help
 	  This driver supports Intel(R) Ethernet Controller I225-LM/I225-V
 	  family of adapters.
--
2.29.2
  
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help