Thread (11 messages) flat view 11 messages, 3 authors, 2021-10-25

Re: [PATCH net-next 1/4] net: bcmgenet: remove netif_carrier_off from adjust_link

From: Andrew Lunn <andrew@lunn.ch>
Date: 2021-09-26 13:59:29
Also in: lkml

On Sat, Sep 25, 2021 at 08:21:11PM -0700, Florian Fainelli wrote:
From: Doug Berger <opendmb@gmail.com>

The bcmgenet_mii_setup() function is registered as the adjust_link
callback from the phylib for the GENET driver.

The phylib always sets the netif_carrier according to phydev->link
prior to invoking the adjust_link callback, so there is no need to
repeat that in the link down case within the network driver.

Signed-off-by: Doug Berger <opendmb@gmail.com>
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>

    Andrew
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help