Re: [PATCH v2 1/2] mwifiex: Use non-posted PCI write when setting TX ring write pointer
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Date: 2021-09-22 13:22:31
Also in:
linux-pci, linux-wireless, lkml, stable
On Wed, Sep 22, 2021 at 02:08:39PM +0200, Jonas Dreßler wrote:
On 9/22/21 1:17 PM, Andy Shevchenko wrote:quoted
On Tue, Sep 14, 2021 at 01:48:12PM +0200, Jonas Dreßler wrote:
...
quoted
Should it have a Fixes tag?Don't think so, there's the infamous (https://bugzilla.kernel.org/show_bug.cgi?id=109681) Bugzilla bug it fixes though, I'll mention that in v3.
Good idea, use BugLink tag for that! ...
Interesting, I haven't noticed that mwifiex_write_reg() always returns 0. So
are you suggesting to remove that return value and get rid of all the "if
(mwifiex_write_reg()) {}" checks in a separate commit?Something like this, yes.
As for why the dummy read/write functions exist, I have no idea. Looking at git history it seems they were always there (only change is that mwifiex_read_reg() started to handle read errors with commit af05148392f50490c662dccee6c502d9fcba33e2). My bet would be that they were created to be consistent with sdio.c which is the oldest supported bus type in mwifiex.
It has a check against all ones. Also your another patch mentioned wake up. Perhaps the purpose is to wake up and return if device was/is in power off mode (D3hot). -- With Best Regards, Andy Shevchenko