Re: [BUG] Re: [PATCH] brcmfmac: use ISO3166 country code and 0 rev as fallback
From: Kalle Valo <hidden>
Date: 2021-09-21 09:21:08
Also in:
linux-rockchip, linux-wireless, lkml
Possibly related (same subject, not in this thread)
- 2021-09-12 · Re: [BUG] Re: [PATCH] brcmfmac: use ISO3166 country code and 0 rev as fallback · Shawn Guo <hidden>
- 2021-09-09 · Re: [BUG] Re: [PATCH] brcmfmac: use ISO3166 country code and 0 rev as fallback · Soeren Moch <hidden>
- 2021-09-09 · Re: [BUG] Re: [PATCH] brcmfmac: use ISO3166 country code and 0 rev as fallback · Shawn Guo <hidden>
- 2021-09-08 · Re: [BUG] Re: [PATCH] brcmfmac: use ISO3166 country code and 0 rev as fallback · Soeren Moch <hidden>
- 2021-09-08 · Re: [BUG] Re: [PATCH] brcmfmac: use ISO3166 country code and 0 rev as fallback · Shawn Guo <hidden>
Shawn Guo [off-list ref] writes:
quoted
Is this not the usual DT policy, that missing optional properties should not prevent a device to work, that old dtbs should still work when new properties are added? I'm not sure what's the best way forward. A plain revert of this patch would at least bring back wifi support for RockPro64 devices with existing dtbs. Maybe someone else has a better proposal how to proceed.Go ahead to revert if we do not hear a better solution, I would say.
Yes, please do send a revert. And remember to explain the regression in the commit log. -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches