Re: [PATCH] octeontx2-af: fix uninitialized variable
From: Nick Desaulniers <ndesaulniers@google.com>
Date: 2021-09-21 02:05:35
Also in:
lkml, llvm
On Mon, Sep 20, 2021 at 9:54 AM [off-list ref] wrote:
From: Tom Rix <trix@redhat.com>
Building with clang 13 reports this error
rvu_nix.c:4600:7: error: variable 'val' is used uninitialized whenever
'if' condition is false
if (!is_rvu_otx2(rvu))
^~~~~~~~~~~~~~~~~
So initialize val.
Fixes: 4b5a3ab17c6c ("octeontx2-af: Hardware configuration for inline IPsec")
Signed-off-by: Tom Rix <trix@redhat.com>
Thanks for the patch, but it looks like Colin beat you to the punch.
In linux-next, I see:
commit d853f1d3c900 ("octeontx2-af: Fix uninitialized variable val")
quoted hunk ↗ jump to hunk
--- drivers/net/ethernet/marvell/octeontx2/af/rvu_nix.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/drivers/net/ethernet/marvell/octeontx2/af/rvu_nix.c b/drivers/net/ethernet/marvell/octeontx2/af/rvu_nix.c index ea3e03fa55d45c..70431db866b328 100644 --- a/drivers/net/ethernet/marvell/octeontx2/af/rvu_nix.c +++ b/drivers/net/ethernet/marvell/octeontx2/af/rvu_nix.c@@ -4592,7 +4592,7 @@ static void nix_inline_ipsec_cfg(struct rvu *rvu, struct nix_inline_ipsec_cfg *r int blkaddr) { u8 cpt_idx, cpt_blkaddr; - u64 val; + u64 val = 0; cpt_idx = (blkaddr == BLKADDR_NIX0) ? 0 : 1; if (req->enable) { --2.26.3
-- Thanks, ~Nick Desaulniers