Re: [PATCH 7/9] net: mdio: mdio-bcm-iproc: simplify getting .driver_data
From: Florian Fainelli <f.fainelli@gmail.com>
Date: 2021-09-21 02:05:15
Also in:
linux-arm-kernel, linux-renesas-soc, lkml
On 9/20/21 2:05 AM, Wolfram Sang wrote:
quoted hunk ↗ jump to hunk
We should get 'driver_data' from 'struct device' directly. Going via platform_device is an unneeded step back and forth. Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com> --- Build tested only. buildbot is happy. drivers/net/mdio/mdio-bcm-iproc.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)diff --git a/drivers/net/mdio/mdio-bcm-iproc.c b/drivers/net/mdio/mdio-bcm-iproc.c index 77fc970cdfde..5666cfab15b9 100644 --- a/drivers/net/mdio/mdio-bcm-iproc.c +++ b/drivers/net/mdio/mdio-bcm-iproc.c@@ -181,8 +181,7 @@ static int iproc_mdio_remove(struct platform_device *pdev) #ifdef CONFIG_PM_SLEEP static int iproc_mdio_resume(struct device *dev) { - struct platform_device *pdev = to_platform_device(dev); - struct iproc_mdio_priv *priv = platform_get_drvdata(pdev); + struct iproc_mdio_priv *priv = dev_get_drvdata(dev);
The change looks good to me, however if you change from platform_get_drvdata() to dev_get_drvdata(), you might also want to change from using platform_set_drvdata() to dev_set_drvdata() for symmetry no? If not, then maybe this patch should be dropped? -- Florian