Thread (4 messages) flat view 4 messages, 2 authors, 2021-09-20

Re: [PATCH] ovs: Only clear tstamp when changing namespaces

From: Cong Wang <hidden>
Date: 2021-09-20 16:41:12
Also in: lkml

On Sun, Sep 19, 2021 at 10:44 PM Tyler Stachecki
[off-list ref] wrote:
Sorry if this is a no-op -- I'm admittedly not familiar with this part
of the tree.  I had added this check based on this discussion on the
OVS mailing list:
https://mail.openvswitch.org/pipermail/ovs-discuss/2021-February/050966.html

The motivation to add it was based on the fact that skb_scrub_packet
is doing it conditionally as well, but you seem to indicate that
skb_scrub_packet itself is already being done somewhere?
I mean, skb->tstamp has been cleared when crossing netns,
so: 1) you don't need to clear it again for this case; 2) clearly we
fix other cases with commit 01634047bf0d, so your patch break
it again.

Thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help