Re: Re: [PATCH net-next] net: net_namespace: Fix undefined member in key_remove_domain()

From: Cong Wang
Date: 2021-09-20 07:25
To: Yajun Deng
CC: David Miller; Jakub Kicinski; Linux Kernel Network Developers; LKML
Subject: Re: [PATCH net-next] net: net_namespace: Fix undefined member in key_remove_domain()
On Sat, Sep 18, 2021 at 7:28 AM Yajun Deng [off-list ref] wrote:

The key_domain member in struct net only exists if we define CONFIG_KEYS.
So we should add the define when we used key_domain.

 
But key_remove_domain() is just a nop if !CONFIG_KEYS:
 
#else /* CONFIG_KEYS */
...
#define key_remove_domain(d)            do { } while(0) 

Yes, you're right.
 
So what exactly are you fixing?
 
Thanks.