Thread (4 messages) flat view 4 messages, 2 authors, 2021-09-19

Re: [PATCH v3 net 0/2] ocelot phylink fixes

From: patchwork-bot+netdevbpf@kernel.org
Date: 2021-09-19 12:10:12
Also in: lkml

Hello:

This series was applied to netdev/net.git (refs/heads/master):

On Fri, 17 Sep 2021 08:39:03 -0700 you wrote:
When the ocelot driver was migrated to phylink, e6e12df625f2 ("net:
mscc: ocelot: convert to phylink") there were two additional writes to
registers that became stale. One write was to DEV_CLOCK_CFG and one was
to ANA_PFC_PCF_CFG.

Both of these writes referenced the variable "speed" which originally
was set to OCELOT_SPEED_{10,100,1000,2500}. These macros expand to
values of 3, 2, 1, or 0, respectively. After the update, the variable
speed is set to SPEED_{10,100,1000,2500} which expand to 10, 100, 1000,
and 2500. So invalid values were getting written to the two registers,
which would lead to either a lack of functionality or undefined
funcationality.

[...]
Here is the summary with links:
  - [v3,net,1/2] net: mscc: ocelot: remove buggy and useless write to ANA_PFC_PFC_CFG
    https://git.kernel.org/netdev/net/c/163957c43d96
  - [v3,net,2/2] net: mscc: ocelot: remove buggy duplicate write to DEV_CLOCK_CFG
    https://git.kernel.org/netdev/net/c/ba68e9941984

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help