On Fri, Sep 17, 2021 at 1:12 AM Bjorn Helgaas [off-list ref] wrote:

On Thu, Sep 16, 2021 at 11:44:17PM +0800, Kai-Heng Feng wrote:

quoted

r8169 NICs on some platforms have abysmal speed when ASPM is enabled.
Same issue can be observed with older vendor drivers.

The issue is however solved by the latest vendor driver. There's a new
mechanism, which disables r8169's internal ASPM when the NIC traffic has
more than 10 packets, and vice versa.

Obviously this is a *rate*, not an absolute number.  I think you mean
something like "10 packets in 1000ms".

Will amend this in next iteration.

quoted

The possible reason for this is
likely because the buffer on the chip is too small for its ASPM exit
latency.

Realtek confirmed that all their PCIe LAN NICs, r8106, r8168 and r8125
use dynamic ASPM under Windows. So implement the same mechanism here to
resolve the issue.

Also introduce a lock to prevent race on accessing config registers.

Can you please include the bugzilla link where you attached lspci
data?  I think it's this:

  https://bugzilla.kernel.org/show_bug.cgi?id=214307

Yes I forgot to add it. Will include in in next iteration.

Kai-Heng

quoted

Signed-off-by: Kai-Heng Feng <redacted>