Re: [PATCH v2] selftests: nci: replace unsigned int with int
From: Bongsu Jeon <hidden>
Date: 2021-09-16 12:08:08
Also in:
linux-kselftest, lkml
I asked you two things. Please check them below. On Thu, Sep 16, 2021 at 8:54 PM Xiang wangx [off-list ref] wrote:
Should not use comparison of unsigned expressions < 0
Please put '.' at the end of the log and add the changelog. For example => Should not use comparison of unsigned expressions < 0.
Signed-off-by: Xiang wangx <redacted> ---
Please add the change log here. For example => Changes since v1 * Change commit log
quoted hunk ↗ jump to hunk
tools/testing/selftests/nci/nci_dev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/tools/testing/selftests/nci/nci_dev.c b/tools/testing/selftests/nci/nci_dev.c index e1bf55dabdf6..162c41e9bcae 100644 --- a/tools/testing/selftests/nci/nci_dev.c +++ b/tools/testing/selftests/nci/nci_dev.c@@ -746,7 +746,7 @@ int read_write_nci_cmd(int nfc_sock, int virtual_fd, const __u8 *cmd, __u32 cmd_ const __u8 *rsp, __u32 rsp_len) { char buf[256]; - unsigned int len; + int len; send(nfc_sock, &cmd[3], cmd_len - 3, 0); len = read(virtual_fd, buf, cmd_len); --2.20.1