Re: [PATCH 4/4] alpha: Use absolute_pointer for strcmp on fixed memory location

From
Linus Torvalds <torvalds@linux-foundation.org>
Date
2021-09-12 19:13:39
Also in
linux-alpha, lkml
Reply to
Guenter Roeck, 2021-09-12
On Sun, Sep 12, 2021 at 9:02 AM Guenter Roeck [off-list ref] wrote:
-       if (strcmp(COMMAND_LINE, "INSTALL") == 0) {
+       if (strcmp(absolute_pointer(COMMAND_LINE), "INSTALL") == 0) {
Again, this feels very much like treating the symptoms, not actually
fixing the real issue.

It's COMMAND_LINE itself that should have been fixed up, not that one use of it.

Because the only reason you didn't get a warning from later uses is
that 'strcmp()' is doing compiler-specific magic. You're just delaying
the inevitable warnings about the other uses of that thing.

            Linus
Thread (14 messages) 14 messages, 4 authors, last reply 2021-09-12
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help